-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connect: ingress gateway validation for http hosts and wildcards #15749
Conversation
changes apply to http, http2, and grpc: * if "hosts" is excluded, consul will use its default domain e.g. <service-name>.ingress.dc1.consul * can't set hosts with "*" service name * test http2 and grpc too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! just the one suggestion. Be sure to set backport labels for 1.4.x, 1.3.x, and 1.2.x
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This makes code match the documentation, and reality 😋
Applies to all non-"tcp" protocols:
http
,http2
, andgrpc
, which support "hosts" and tests now cover all of them as well. I could maybe be convinced to remove the extra test coverage if it seems superfluous, but it's intended to guard against potential future regressions.per https://developer.hashicorp.com/nomad/docs/job-specification/gateway#service-parameters,
e.g. this will now work:
and this will no longer work (by "work" I mean pass to consul, which errors less-specifically):
error before:
error after:
Closes #10955
Note: to use these non-"tcp" protocols, users will still need to manually write a service-defaults Consul config entry as described in #8647 (comment)